Messages in this thread | | | Subject | Re: [PATCH 2/2] RTL8153-BD is used in Dell DA300 type-C dongle. It should be added to the whitelist of devices to activate MAC address pass through. | From | David Chen <> | Date | Mon, 18 Feb 2019 16:24:45 +0800 |
| |
Hi Oliver,
Thanks for reviewing. I have made some mistake, will correct it and resend.
Thanks and Regards, -David
> Oliver Neukum <oneukum@suse.com> 於 2019年2月18日 下午4:04 寫道: > >> On Mo, 2019-02-18 at 11:48 +0800, David Chen wrote: >> From: David Chen <david.chen7@dell.com> >> >> Per confirming with Realtek all devices containing RTL8153-BD should >> activate MAC pass through and there won't use pass through bit on efuse >> like in RTL8153-AD. >> >> Signed-off-by: David Chen <david.chen7@dell.com> >> --- >> drivers/net/usb/r8152.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c >> index ada6baf8847a..86c8c64fbb0f 100644 >> --- a/drivers/net/usb/r8152.c >> +++ b/drivers/net/usb/r8152.c >> @@ -1179,7 +1179,7 @@ static int vendor_mac_passthru_addr_read(struct r8152 *tp, struct sockaddr *sa) >> } else { >> /* test for RTL8153-BND and RTL8153-BD */ >> ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_MISC_1); >> - if ((ocp_data & BND_MASK) == 0 && (ocp_data & BD_MASK)) { >> + if ((ocp_data & BND_MASK) == 0 && (ocp_data & BD_MASK) == 0) { > > You are inverting the second half of the test. How can this possibly be > right? Had you dropped it, I would understand. But this? Are you sure? > > Regards > Oliver >
| |