Messages in this thread | | | Date | Mon, 18 Feb 2019 14:28:45 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCH V2 5/7] dt-bindings: interrupt-controller: Update csky mpintc |
| |
On Mon, 18 Feb 2019 10:04:41 +0800 guoren@kernel.org wrote:
> From: Guo Ren <ren_guo@c-sky.com> > > Add trigger type and priority setting for csky,mpintc. > > Changelog: > - change #interrupt-cells to <3> > > Signed-off-by: Guo Ren <ren_guo@c-sky.com> > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: Rob Herring <robh+dt@kernel.org> > --- > .../bindings/interrupt-controller/csky,mpintc.txt | 21 +++++++++++++++++---- > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt b/Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt > index ab921f1..dccd913 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt > @@ -6,11 +6,18 @@ C-SKY Multi-processors Interrupt Controller is designed for ck807/ck810/ck860 > SMP soc, and it also could be used in non-SMP system. > > Interrupt number definition: > - > 0-15 : software irq, and we use 15 as our IPI_IRQ. > 16-31 : private irq, and we use 16 as the co-processor timer. > 31-1024: common irq for soc ip. > > +Interrupt triger mode: > + IRQ_TYPE_LEVEL_HIGH (default) > + IRQ_TYPE_LEVEL_LOW > + IRQ_TYPE_EDGE_RISING > + IRQ_TYPE_EDGE_FALLING > + > +Interrupt priority range: 0-255 > + > ============================= > intc node bindings definition > ============================= > @@ -26,15 +33,21 @@ intc node bindings definition > - #interrupt-cells > Usage: required > Value type: <u32> > - Definition: must be <1> > + Definition: <3>
This seem to be invalidating all existing DTs. Is this an acceptable thing to do? It will require an Ack from a DT maintainer.
> - interrupt-controller: > Usage: required > > -Examples: > +Examples: ("interrupts = <irq_num IRQ_TYPE_XXX priority>") > --------- > > intc: interrupt-controller { > compatible = "csky,mpintc"; > - #interrupt-cells = <1>; > + #interrupt-cells = <3>; > interrupt-controller; > }; > + > + device: device-example { > + ... > + interrupts = <34 IRQ_TYPE_EDGE_RISING 254>; > + interrupt-parent = <&intc>; > + };
Thanks,
M. -- Without deviation from the norm, progress is not possible.
| |