Messages in this thread | | | Date | Mon, 18 Feb 2019 00:06:22 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH v3 perf,bpf 10/11] perf, bpf: enable annotation of bpf program |
| |
On Fri, Feb 15, 2019 at 01:53:53PM -0800, Song Liu wrote:
SNIP
> int machine__process_bpf_event(struct machine *machine __maybe_unused, > union perf_event *event, > struct perf_sample *sample __maybe_unused) > { > if (dump_trace) > perf_event__fprintf_bpf_event(event, stdout); > + > + switch (event->bpf_event.type) { > + case PERF_BPF_EVENT_PROG_LOAD: > + return machine__process_bpf_event_load(machine, event, sample); > + > + case PERF_BPF_EVENT_PROG_UNLOAD: > + break;
could we make a comment here, descriving why we dont remove bpf programs.. which I assume is intentional
thanks, jirka
| |