Messages in this thread | | | Date | Mon, 18 Feb 2019 00:41:49 +0530 | From | Akshay Adiga <> | Subject | Re: [PATCH] cpufreq: powernv: fix missing check of return value in init_powernv_pstates() |
| |
On Sat, Feb 16, 2019 at 12:06:23PM -0500, Yangtao Li wrote: > kmalloc() could fail, so insert a check of its return value. And > if it fails, returns -ENOMEM. > > And remove (struct pstate_idx_revmap_data *) to fix coccinelle WARNING > by the way. > > WARNING: casting value returned by memory allocation function to (struct > pstate_idx_revmap_data *) is useless. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/cpufreq/powernv-cpufreq.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Looks good to me. Thanks for fixing this.
| |