Messages in this thread | | | Date | Sat, 16 Feb 2019 09:32:24 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [v5] Coccinelle: semantic code search for missing put_device() |
| |
On Sat, 16 Feb 2019, Markus Elfring wrote:
> >> We will modify the the if in the when code like this: > >> > >> @@ -22,7 +22,7 @@ if (id == NULL || ...) { ... return ...; } > >> ... when != put_device(&id->dev) > … > >> - when != if (id) { ... put_device(&id->dev) ... } > >> + when != if (...) { ... put_device(&id->dev) ... } > > > > This looks ok. > > I have got another different software development opinion also for > such SmPL code in the adjusted line. > I find this specific source code search variant irrelevant > because the shown reference release function should be found > by the first SmPL when specification already. > Would you like to determine generally if the desired function call > is present at all? > > Thus I do not see a need (or requirement) for a duplicate search attempt.
Why don't you actually try it and see what the difference is rather than repeatedly giving false information?
julia
| |