Messages in this thread | | | Subject | Re: [RFC PATCH v8 03/14] mm, x86: Add support for eXclusive Page Frame Ownership (XPFO) | From | Khalid Aziz <> | Date | Thu, 14 Feb 2019 10:19:23 -0700 |
| |
On 2/14/19 9:15 AM, Borislav Petkov wrote: > On Thu, Feb 14, 2019 at 11:56:31AM +0100, Peter Zijlstra wrote: >>> +EXPORT_SYMBOL(xpfo_kunmap); >> >> And these here things are most definitely not IRQ-safe. > > Should also be EXPORT_SYMBOL_GPL. >
Agreed. On the other hand, is there even a need to export this? It should only be called from kunmap() or kunmap_atomic() and not from any module directly. Same for xpfo_kmap.
Thanks, Khalid [unhandled content-type:application/pgp-keys] | |