lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mfd: twl6040: Fix device init errors for ACCCTL register
* Lee Jones <lee.jones@linaro.org> [190214 09:21]:
> On Mon, 11 Feb 2019, Tony Lindgren wrote:
> > + ret = regcache_sync(twl6040->regmap);
> > + if (ret) {
> > + dev_err(twl6040->dev, "%s register write failed: %i\n",
> > + __func__, ret);
>
> Please drop the __func__ and just use the standard format.
>
> Wouldn't something a little more forthcoming be better?
>
> "Failed to sync with the HW" ?

Sure I'll send an updated patch.

Regards,

Tony

\
 
 \ /
  Last update: 2019-02-14 17:03    [W:0.062 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site