lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [RFC 5/5] arm64: dts: imx8mq: Add the opp table and the cpu-supply nodes
From
Date
Hi Abel

Am Mittwoch, den 13.02.2019, 19:05 +0000 schrieb Abel Vesa:
> Add the opp table containing only non over drive opps.
> Also add the cpu-supply nodes for the A53 cores in the EVK board.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 17 +++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi    | 23 +++++++++++++++++++++++
>  2 files changed, 40 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index 54737bf..114359e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -31,6 +31,23 @@
>   gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
>   enable-active-high;
>   };
> +
> +};
> +
> +&A53_0 {
> + cpu-supply = <&sw1a_reg>;
> +};
> +
> +&A53_1 {
> + cpu-supply = <&sw1a_reg>;
> +};
> +
> +&A53_2 {
> + cpu-supply = <&sw1a_reg>;
> +};
> +
> +&A53_3 {
> + cpu-supply = <&sw1a_reg>;
>  };

This should be a separate patch.

And AFAICS this is wrong, sw1a on the MX8M-EVK is the GPU supply, the
CPU is supplied by a dedicated switcher that is controlled via a GPIO.

Regards,
Lucas

>  &fec1 {
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 1a89062..89b2d5f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -91,6 +91,7 @@
>   clocks = <&clk IMX8MQ_CLK_ARM>;
>   enable-method = "psci";
>   next-level-cache = <&A53_L2>;
> + operating-points-v2 = <&a53_0_opp_table>;
>   };
>  
>   A53_1: cpu@1 {
> @@ -101,6 +102,7 @@
>   clocks = <&clk IMX8MQ_CLK_ARM>;
>   enable-method = "psci";
>   next-level-cache = <&A53_L2>;
> + operating-points-v2 = <&a53_0_opp_table>;
>   };
>  
>   A53_2: cpu@2 {
> @@ -111,6 +113,7 @@
>   clocks = <&clk IMX8MQ_CLK_ARM>;
>   enable-method = "psci";
>   next-level-cache = <&A53_L2>;
> + operating-points-v2 = <&a53_0_opp_table>;
>   };
>  
>   A53_3: cpu@3 {
> @@ -121,6 +124,7 @@
>   clocks = <&clk IMX8MQ_CLK_ARM>;
>   enable-method = "psci";
>   next-level-cache = <&A53_L2>;
> + operating-points-v2 = <&a53_0_opp_table>;
>   };
>  
>   A53_L2: l2-cache0 {
> @@ -666,6 +670,25 @@
>   status = "disabled";
>   };
>  
> +
> + a53_0_opp_table: opp-table {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp-800000000 {
> + opp-hz = /bits/ 64 <800000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <150000>;
> + };
> +
> + opp-1000000000 {
> + opp-hz = /bits/ 64 <1000000000>;
> + opp-microvolt = <900000>;
> + clock-latency-ns = <150000>;
> + opp-suspend;
> + };
> + };
> +
>   gic: interrupt-controller@38800000 {
>   compatible = "arm,gic-v3";
>   reg = <0x38800000 0x10000>, /* GIC
> Dist */

\
 
 \ /
  Last update: 2019-02-14 16:51    [W:0.091 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site