Messages in this thread | | | Subject | Re: [PATCH v3 Resend 09/13] ASoC: dmaengine: Remove unused SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME flag | From | Sylwester Nawrocki <> | Date | Thu, 14 Feb 2019 15:32:38 +0100 |
| |
On 2/14/19 14:07, Mark Brown wrote: > On Thu, Feb 14, 2019 at 10:37:43AM +0100, Sylwester Nawrocki wrote: > >> u32 maxburst; >> unsigned int slave_id; >> void *filter_data; >> - const char *chan_name; >> unsigned int fifo_size; >> unsigned int flags; > > This fails to build: > > CC sound/core/pcm_dmaengine.o > sound/arm/pxa2xx-pcm-lib.c: In function ‘pxa2xx_pcm_open’: > sound/arm/pxa2xx-pcm-lib.c:128:22: error: ‘struct snd_dmaengine_dai_dma_data’ has no member named ‘chan_name’ > dma_params->chan_name)); > ^~ > sound/arm/pxa2xx-pcm-lib.c:129:1: warning: control reaches end of non-void function [-Wreturn-type] > } > ^
Hm, looks like we need still to keep that data structure field, but remaining part of the patch could be applied. Do you want me to resend it with chan_name removal part dropped? The $subject patch is optional so we could also skip it and apply remaining patches so there is no another resend.
| |