lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 7/9] x86/alternative: Batch of patch operations
On Thu, Feb 14, 2019 at 09:06:20AM -0500, Steven Rostedt wrote:
> Although you did say above that "patch" is an overloaded term. Also, I
> do find the current name rather descriptive.

When you look at "text_to_poke" as a struct name, you go, WTF is that?
The whole text? Some of it?

It should have the word "location" in it, to be clearer IMO.

> void *trampoline;

Well, it ain't a trampoline either. It is a "temporary location to go to while
patching is going on". Now make that a member name!

:-)))

> But they are named after you! "bp_" :-)

Uuh, you shouldn't have! :-)

Then they *must* be changed immediately!

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

\
 
 \ /
  Last update: 2019-02-14 15:31    [W:0.153 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site