Messages in this thread | | | Date | Thu, 14 Feb 2019 14:38:06 +0200 | From | Matti Vaittinen <> | Subject | Re: [PATCH v9 5/8] gpio: Initial support for ROHM bd70528 GPIO block |
| |
Hello Linus,
On Thu, Feb 14, 2019 at 10:29:01AM +0200, Matti Vaittinen wrote: > Thanks a bunch Linus, > > On Thu, Feb 14, 2019 at 09:00:33AM +0100, Linus Walleij wrote: > > On Wed, Feb 13, 2019 at 2:34 PM Matti Vaittinen > > <matti.vaittinen@fi.rohmeurope.com> wrote: > > > > Just spotted this: > > > > > +#include <linux/gpio/driver.h> > > > +#include <linux/gpio.h> > > > > A driver should only need <linux/gpio/driver.h> > > the <linux/gpio.h> should not be used at all in new code, > > it is a legacy header. > > Allright. I'll do v10 and drop the header. Thanks for pointing this out
It seems to me the GPIOF_DIR_XXX are defined in linux/gpio.h. It would be nice to refer to these flags when interpreting the return value from the bd70528_get_direction (used in bd70528_gpio_get) - and actually it might be nice to use those as a return value from bd70528_get_direction.
But I'll go with raw values for now and leave possible definition moving/header refactoring to you who know the direction of code better :)
Br, Matti Vaittinen
-- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
| |