Messages in this thread Patch in this message | | | Date | Thu, 14 Feb 2019 10:46:25 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect_ twice for Device table |
| |
On Sun, 10 Feb 2019 05:24:10 +0000, Zenghui Yu <yuzenghui@huawei.com> wrote: > > In current logic, its_parse_indirect_baser() will be invoked twice > when allocating Device tables. Add a *break* to omit the unnecessary > and annoying (might be ...) invoking. > > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> > --- > drivers/irqchip/irq-gic-v3-its.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index db20e99..9f529a6 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -1946,6 +1946,8 @@ static int its_alloc_tables(struct its_node *its) > indirect = its_parse_indirect_baser(its, baser, > psz, &order, > its->device_ids); > + break; > + > case GITS_BASER_TYPE_VCPU: > indirect = its_parse_indirect_baser(its, baser, > psz, &order,
Nice catch. I've applied this to irqchip-next with the Fixes tag and a Cc stable.
Thanks,
M.
-- Jazz is not dead, it just smell funny.
| |