Messages in this thread | | | Subject | Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs | From | Hans de Goede <> | Date | Thu, 14 Feb 2019 11:04:44 +0100 |
| |
Hi,
On 13-02-19 23:43, Hans de Goede wrote: > Hi, > > On 12-02-19 21:59, Yauhen Kharuzhy wrote: >> Add support for LEDs connected to the Intel Cherry Trail Whiskey Cove >> PMIC. Charger and general-purpose leds are supported. Hardware blinking >> is implemented, breathing is not. >> >> This driver was tested with Lenovo Yoga Book notebook.
<snip>
> Note that in my experience the "charging" mode only works > when bits 0-1 have the value 10.
Ok, scrap that I don't know where this info in my notes came from (probably user error), the power-on-reset value for bits 0-1 is 00 and then the hw controls the charging LED just fine. So your code is right, bit 0 switches between hw-control (0) and user-control (1) and bit 1 is on/off when user-control is enabled.
Regards,
Hans
| |