lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v3 1/6] dt-bindings: add binding for USBSS-DRD controller.
    Date
    Hi Rob,
    >On Thu, Jan 31, 2019 at 11:52:28AM +0000, Pawel Laszczak wrote:
    >> This patch aim at documenting USB related dt-bindings for the
    >> Cadence USBSS-DRD controller.
    >>
    >> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
    >> ---
    >> .../devicetree/bindings/usb/cdns-usb3.txt | 33 +++++++++++++++++++
    >> 1 file changed, 33 insertions(+)
    >> create mode 100644 Documentation/devicetree/bindings/usb/cdns-usb3.txt
    >>
    >> diff --git a/Documentation/devicetree/bindings/usb/cdns-usb3.txt b/Documentation/devicetree/bindings/usb/cdns-usb3.txt
    >> new file mode 100644
    >> index 000000000000..6dc38be77f5c
    >> --- /dev/null
    >> +++ b/Documentation/devicetree/bindings/usb/cdns-usb3.txt
    >> @@ -0,0 +1,33 @@
    >> +Binding for the Cadence USBSS-DRD controller
    >> +
    >> +Required properties:
    >> + - reg: Physical base address and size of the controller's register areas.
    >> + Controller has 3 different regions:
    >> + region 1 - HOST registers area
    >> + region 2 - DEVICE registers area
    >> + region 3 - OTG/DRD registers area
    >> + - reg-names - register memory area names:
    >> + "xhci" - for HOST registers space
    >> + "dev" - for DEVICE registers space
    >> + "otg" - for OTG/DRD registers space
    >> + - compatible: Should contain: "cdns,usb3-1.0.0" or "cdns,usb3-1.0.1"
    >> + - interrupts: Interrupt specifier. Refer to interrupt bindings.
    >> + Driver supports only single interrupt line.
    >
    >Driver supports or h/w only has 1 interrupt?

    h/w internally has 3 separate interrupt line, but in my testing board
    they are ored. So physically driver sees only one h/w interrupt line and
    assumes that h/w has single common interrupt line.

    >
    >> + This single interrupt is shared between Device,
    >> + host and OTG/DRD part of driver.
    >> +
    >> +Optional properties:
    >> + - maximum-speed : valid arguments are "super-speed", "high-speed" and
    >> + "full-speed"; refer to usb/generic.txt
    >> + - dr_mode: Should be one of "host", "peripheral" or "otg".
    >> + - phys: reference to the USB PHY
    >> +
    >> +Example:
    >> + usb@f3000000 {
    >> + compatible = "cdns,usb3";
    >
    >Doesn't match above.
    Right, should be:
    Compatible = " cdns,usb3-1.0.0", "cdns,usb3-1.0.1";
    >
    >> + interrupts = <USB_IRQ 7 IRQ_TYPE_LEVEL_HIGH>;
    >> + reg = <0xf3000000 0x10000 /* memory area for HOST registers */
    >> + 0xf3010000 0x10000 /* memory area for DEVICE registers */
    >> + 0xf3020000 0x10000>; /* memory area for OTG/DRD registers */
    >
    >Are these really 64KB long? That wastes virtual address space on 32-bit
    >systems if not.

    Yes, on my testing platform it takes 64KB. It's only example, and it could be limited.
    >
    >> + reg-names = "xhci", "dev", "otg";
    >> + };
    >> --
    >> 2.17.1
    >>
    Thanks
    Pawel

    \
     
     \ /
      Last update: 2019-02-14 07:10    [W:2.529 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site