Messages in this thread | | | Date | Thu, 14 Feb 2019 09:16:17 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: mxs-lradc: Mark expected switch fall-through |
| |
On Mon, 11 Feb 2019, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/mfd/mxs-lradc.c: In function ‘mxs_lradc_probe’: > drivers/mfd/mxs-lradc.c:179:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (lradc->soc == IMX28_LRADC) { > ^ > drivers/mfd/mxs-lradc.c:185:3: note: here > default: > ^~~~~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in this particular case, the code comment is modified > in accordance with what GCC is expecting to find. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/mfd/mxs-lradc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |