lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.20 06/77] ASoC: soc-core: defer card probe until all component is added to list
    Date
    From: Ajit Pandey <ajitp@codeaurora.org>

    [ Upstream commit 8780cf1142a59568a3aa77959cbd76b2edb6fd81 ]

    DAI component probe is not called if it is not present
    in component list during sound card registration.
    Check if component is available in component list for
    platform and cpu dai before soundcard registration.

    Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
    Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/soc-core.c | 17 ++++++++++++++++-
    1 file changed, 16 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
    index b29d0f65611e..74b12f90ea9b 100644
    --- a/sound/soc/soc-core.c
    +++ b/sound/soc/soc-core.c
    @@ -1027,7 +1027,6 @@ static int snd_soc_init_platform(struct snd_soc_card *card,
    struct snd_soc_dai_link *dai_link)
    {
    struct snd_soc_dai_link_component *platform = dai_link->platform;
    -
    /*
    * FIXME
    *
    @@ -1129,6 +1128,14 @@ static int soc_init_dai_link(struct snd_soc_card *card,
    link->name);
    return -EINVAL;
    }
    +
    + /*
    + * Defer card registartion if platform dai component is not added to
    + * component list.
    + */
    + if (!soc_find_component(link->platform->of_node, link->platform->name))
    + return -EPROBE_DEFER;
    +
    /*
    * CPU device may be specified by either name or OF node, but
    * can be left unspecified, and will be matched based on DAI
    @@ -1140,6 +1147,14 @@ static int soc_init_dai_link(struct snd_soc_card *card,
    link->name);
    return -EINVAL;
    }
    +
    + /*
    + * Defer card registartion if cpu dai component is not added to
    + * component list.
    + */
    + if (!soc_find_component(link->cpu_of_node, link->cpu_name))
    + return -EPROBE_DEFER;
    +
    /*
    * At least one of CPU DAI name or CPU device name/node must be
    * specified
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-02-15 03:43    [W:3.192 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site