lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] soc: qcom: rpmhpd: Set 'active_only' for active only power domains
From
Date

On 2/14/2019 11:06 PM, Douglas Anderson wrote:
> The 'active_only' attribute was accidentally never set to true for any
> power domains meaning that all the code handling this attribute was
> dead.
>
> NOTE that the RPM power domain code (as opposed to the RPMh one) gets
> this right.
>
> Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Thanks for catching this. I seem to have introduced this bug when I moved
away from using the macros to define these static structs and failed to add
the property :/

Acked-by: Rajendra Nayak <rnayak@codeaurora.org>

> ---
>
> drivers/soc/qcom/rpmhpd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index 5741ec3fa814..51850cc68b70 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -93,6 +93,7 @@ static struct rpmhpd sdm845_mx = {
>
> static struct rpmhpd sdm845_mx_ao = {
> .pd = { .name = "mx_ao", },
> + .active_only = true,
> .peer = &sdm845_mx,
> .res_name = "mx.lvl",
> };
> @@ -107,6 +108,7 @@ static struct rpmhpd sdm845_cx = {
>
> static struct rpmhpd sdm845_cx_ao = {
> .pd = { .name = "cx_ao", },
> + .active_only = true,
> .peer = &sdm845_cx,
> .parent = &sdm845_mx_ao.pd,
> .res_name = "cx.lvl",
>

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

\
 
 \ /
  Last update: 2019-02-15 03:33    [W:0.063 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site