lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 10/23] locking/lockdep: Update two outdated comments
    Date
    synchronize_sched() has been removed recently. Update the comments that
    refer to synchronize_sched().

    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Waiman Long <longman@redhat.com>
    Cc: Johannes Berg <johannes@sipsolutions.net>
    Fixes: 51959d85f32d ("lockdep: Replace synchronize_sched() with synchronize_rcu()") # v5.0-rc1
    Signed-off-by: Bart Van Assche <bvanassche@acm.org>
    ---
    kernel/locking/lockdep.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
    index 42161b8f0e68..4bab8ecb88be 100644
    --- a/kernel/locking/lockdep.c
    +++ b/kernel/locking/lockdep.c
    @@ -4200,9 +4200,9 @@ static void __lockdep_free_key_range(void *start, unsigned long size)
    * Used in module.c to remove lock classes from memory that is going to be
    * freed; and possibly re-used by other modules.
    *
    - * We will have had one sync_sched() before getting here, so we're guaranteed
    - * nobody will look up these exact classes -- they're properly dead but still
    - * allocated.
    + * We will have had one synchronize_rcu() before getting here, so we're
    + * guaranteed nobody will look up these exact classes -- they're properly dead
    + * but still allocated.
    */
    void lockdep_free_key_range(void *start, unsigned long size)
    {
    @@ -4221,8 +4221,6 @@ void lockdep_free_key_range(void *start, unsigned long size)
    /*
    * Wait for any possible iterators from look_up_lock_class() to pass
    * before continuing to free the memory they refer to.
    - *
    - * sync_sched() is sufficient because the read-side is IRQ disable.
    */
    synchronize_rcu();

    --
    2.21.0.rc0.258.g878e2cd30e-goog
    \
     
     \ /
      Last update: 2019-02-15 00:02    [W:3.327 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site