[lkml]   [2019]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 4.20 17/50] debugfs: fix debugfs_rename parameter checking
    4.20-stable review patch.  If anyone has any objections, please let me know.


    From: Greg Kroah-Hartman <>

    commit d88c93f090f708c18195553b352b9f205e65418f upstream.

    debugfs_rename() needs to check that the dentries passed into it really
    are valid, as sometimes they are not (i.e. if the return value of
    another debugfs call is passed into this one.) So fix this up by
    properly checking if the two parent directories are errors (they are
    allowed to be NULL), and if the dentry to rename is not NULL or an

    Cc: stable <>
    Signed-off-by: Greg Kroah-Hartman <>

    fs/debugfs/inode.c | 7 +++++++
    1 file changed, 7 insertions(+)

    --- a/fs/debugfs/inode.c
    +++ b/fs/debugfs/inode.c
    @@ -787,6 +787,13 @@ struct dentry *debugfs_rename(struct den
    struct dentry *dentry = NULL, *trap;
    struct name_snapshot old_name;

    + if (IS_ERR(old_dir))
    + return old_dir;
    + if (IS_ERR(new_dir))
    + return new_dir;
    + if (IS_ERR_OR_NULL(old_dentry))
    + return old_dentry;
    trap = lock_rename(new_dir, old_dir);
    /* Source or destination directories don't exist? */
    if (d_really_is_negative(old_dir) || d_really_is_negative(new_dir))

     \ /
      Last update: 2019-02-13 19:47    [W:3.854 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site