Messages in this thread | | | Subject | Re: [PATCH v2] staging: comedi: ni_660x: fix missing break in switch statement | From | "Gustavo A. R. Silva" <> | Date | Wed, 13 Feb 2019 12:17:42 -0600 |
| |
On 2/13/19 4:41 AM, Ian Abbott wrote: > On 12/02/2019 18:44, Gustavo A. R. Silva wrote: >> Add missing break statement in order to prevent the code from falling >> through to the default case and return -EINVAL every time. >> >> This bug was found thanks to the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Fixes: aa94f2888825 ("staging: comedi: ni_660x: tidy up ni_660x_set_pfi_routing()") >> Cc: stable@vger.kernel.org >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> Changes in v2: >> - Fix Fixes tag. >> >> drivers/staging/comedi/drivers/ni_660x.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c >> index e70a461e723f..405573e927cf 100644 >> --- a/drivers/staging/comedi/drivers/ni_660x.c >> +++ b/drivers/staging/comedi/drivers/ni_660x.c >> @@ -656,6 +656,7 @@ static int ni_660x_set_pfi_routing(struct comedi_device *dev, >> case NI_660X_PFI_OUTPUT_DIO: >> if (chan > 31) >> return -EINVAL; >> + break; >> default: >> return -EINVAL; >> } >> > > Thanks for the bug fix! >
Glad to help. :)
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> >
Thanks, Ian.
-- Gustavo
| |