Messages in this thread | | | Date | Wed, 13 Feb 2019 12:02:38 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH v4 05/10] mfd: max77650: new core mfd driver |
| |
Hi!
> > As you can see, it will return the IRQ Domain for the chip. > > > > You can then pass this IRQ domain to mfd_add_devices() and it will do > > the HWIRQ => VIRQ mapping for you on the fly. Meaning that you can > > remove all the nastiness in max77650_setup_irqs() and have the Input > > device use the standard (e.g. platform_get_irq()) APIs. > > > > How does that Sound? > > This does sound better! Why didn't you lead with that in the first >place?
TBH, this can be considered rude and I'm not surprised Lee reacted the way he did.
> It's a pity it's not documented, I had to look at the code to find out > irq resources would get translated in mfd_add_devices() if a domain is > present.
I guess documentation patch would be welcome.
Best regards, Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |