lkml.org 
[lkml]   [2019]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 V2 10/17] ARM: 8810/1: vfp: Fix wrong assignement to ufp_exc
    Date
    From: Julien Thierry <julien.thierry@arm.com>

    Commit 5df7a99bdd0de4a0480320264c44c04543c29d5a upstream.

    In vfp_preserve_user_clear_hwstate, ufp_exc->fpinst2 gets assigned to
    itself. It should actually be hwstate->fpinst2 that gets assigned to the
    ufp_exc field.

    Fixes commit 3aa2df6ec2ca6bc143a65351cca4266d03a8bc41 ("ARM: 8791/1:
    vfp: use __copy_to_user() when saving VFP state").

    Reported-by: David Binderman <dcb314@hotmail.com>
    Signed-off-by: Julien Thierry <julien.thierry@arm.com>
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: David A. Long <dave.long@linaro.org>
    ---
    arch/arm/vfp/vfpmodule.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c
    index 6bacd69c9e81..8e11223d32a1 100644
    --- a/arch/arm/vfp/vfpmodule.c
    +++ b/arch/arm/vfp/vfpmodule.c
    @@ -579,7 +579,7 @@ int vfp_preserve_user_clear_hwstate(struct user_vfp *ufp,
    */
    ufp_exc->fpexc = hwstate->fpexc;
    ufp_exc->fpinst = hwstate->fpinst;
    - ufp_exc->fpinst2 = ufp_exc->fpinst2;
    + ufp_exc->fpinst2 = hwstate->fpinst2;

    /* Ensure that VFP is disabled. */
    vfp_flush_hwstate(thread);
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-02-14 03:11    [W:2.632 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site