Messages in this thread | | | Date | Thu, 14 Feb 2019 10:26:12 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] printk: add KERN_NOTIME to skip the timestamp |
| |
On (02/13/19 09:31), Steven Rostedt wrote: > > Without this patch: > > [ 10.991426] virtio_rpmsg_bus virtio1: rpmsg host is online > > [ 10.991443] remoteproc remoteproc1: registered virtio1 (type 7) > > [ 10.991450] remoteproc remoteproc1: remote processor > > f9210000.toppwr:sen-rproc is now up > > [ 10.993715] virtio_rpmsg_bus virtio1: creating channel > > rpmsg-ttySENSOR addr 0x1 > > [ 10.994606] virtio_rpmsg_bus virtio1: creating channel rpmsg-ttyGPS addr 0x2 > > [ 10.995236] virtio_rpmsg_bus virtio1: creating channel rpmsg-clk addr 0x3 > > [ 10.995702] virtio_rpmsg_bus virtio1: creating channel rpmsg-syslog addr 0x4 > > [ 10.996197] virtio_rpmsg_bus virtio1: creating channel rpmsg-rtc addr 0x5 > > [ 10.997297] virtio_rpmsg_bus virtio1: creating channel rpmsg-hostfs addr 0x6 > > [ 10.999842] virtio_rpmsg_bus virtio1: creating channel rpmsg-usrsock addr 0x7 > > [ 11.105345][ 0.007680] sensor: NuttX sensor 7.28 e3c2ecb Feb 12 > > 2019 16:53:49 arm song/banks > > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > > [ 11.918177] random: crng init done > > [ 12.567362] e2fsck: e2fsck 1.42.9 (28-Dec-2013) > > > > Which one do you think better? > > Honestly, the one without the patch.
+1
> Seriously, it also makes it easy to see where that message happened > with respect to the other printks. With your patch, we would have no > idea, and if I was a normal user, unaware of this patch, I would > probably submit a bug report claiming that something is wrong with the > timestamps.
+1
-ss
| |