Messages in this thread | | | Date | Thu, 14 Feb 2019 08:44:58 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH -tip v3 05/10] kprobes: Search non-suffixed symbol in blacklist |
| |
On Wed, 13 Feb 2019 08:17:11 +0100 Ingo Molnar <mingo@kernel.org> wrote:
> > * Ingo Molnar <mingo@kernel.org> wrote: > > > > > * Masami Hiramatsu <mhiramat@kernel.org> wrote: > > > > > Newer gcc can generate some different instances of a function > > > with suffixed symbols if the function is optimized and only > > > has a part of that. (e.g. .constprop, .part etc.) > > > > > > In this case, it is not enough to check the entry of kprobe > > > blacklist because it only records non-suffixed symbol address. > > > > > > To fix this issue, search non-suffixed symbol in blacklist if > > > given address is within a symbol which has a suffix. > > > > > > Note that this can cause false positive cases if a kprobe-safe > > > function is optimized to suffixed instance and has same name > > > symbol which is blacklisted. > > > But I would like to chose a fail-safe design for this issue. > > > > > > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> > > > > Why did you not add Steven's Reviewed-by tag? > > The series looks fine otherwise, so I applied it with Steve's reviewed-by > tag added.
Oops, sorry! I missed to add that. :-(
Thank you,
> > Thanks, > > Ingo
-- Masami Hiramatsu <mhiramat@kernel.org>
| |