Messages in this thread | | | Date | Tue, 12 Feb 2019 13:46:37 -0500 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [PATCH] iscsi_ibft: Fix missing break in switch statement |
| |
On Mon, Feb 11, 2019 at 12:43:23PM -0600, Gustavo A. R. Silva wrote: > Add missing break statement in order to prevent the code from falling > through to case ISCSI_BOOT_TGT_NAME, which is unnecessary. > > This bug was found thanks to the ongoing efforts to enable > -Wimplicit-fallthrough. > > Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib") > Cc: stable@vger.kernel.org > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Queued it up in https://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft.git > --- > drivers/firmware/iscsi_ibft.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c > index 6bc8e6640d71..c51462f5aa1e 100644 > --- a/drivers/firmware/iscsi_ibft.c > +++ b/drivers/firmware/iscsi_ibft.c > @@ -542,6 +542,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type) > case ISCSI_BOOT_TGT_NIC_ASSOC: > case ISCSI_BOOT_TGT_CHAP_TYPE: > rc = S_IRUGO; > + break; > case ISCSI_BOOT_TGT_NAME: > if (tgt->tgt_name_len) > rc = S_IRUGO; > -- > 2.20.1 >
| |