Messages in this thread | | | From | Alan Tull <> | Date | Tue, 12 Feb 2019 11:07:01 -0600 | Subject | Re: [PATCH v3 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp |
| |
On Tue, Feb 12, 2019 at 5:06 AM Moritz Fischer <moritz.fischer@ettus.com> wrote:
Hi Nava,
> > + mgr = fpga_mgr_create(dev, "Xilinx ZynqMP FPGA Manager", > > + &zynqmp_fpga_ops, priv);
Please use the new devm_fpga_mgr_create()
> > + if (!mgr) > > + return -ENOMEM; > > + > > + platform_set_drvdata(pdev, mgr); > > + > > + err = fpga_mgr_register(mgr); > vs here. > > + if (err) { > > + dev_err(dev, "unable to register FPGA manager"); > > + fpga_mgr_free(mgr);
With devm_fpga_mgr_create(), this fpga_mgr_free() can go away.
> > + return err; > > + } > > + > > + return 0;
Thanks, Alan
| |