Messages in this thread | | | Subject | Re: [PATCH] ser_gigaset: mark expected switch fall-through | From | "Gustavo A. R. Silva" <> | Date | Tue, 12 Feb 2019 08:58:11 -0600 |
| |
On 2/12/19 2:45 AM, Paul Bolle wrote: > Gustavo A. R. Silva schreef op ma 11-02-2019 om 16:34 [-0600]: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warning: >> >> drivers/isdn/gigaset/ser-gigaset.c: In function ‘gigaset_tty_ioctl’: >> drivers/isdn/gigaset/ser-gigaset.c:627:3: warning: this statement may fall through [-Wimplicit-fallthrough=] >> switch (arg) { >> ^~~~~~ >> drivers/isdn/gigaset/ser-gigaset.c:638:2: note: here >> default: >> ^~~~~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> Notice that, in this particular case, the code comment is modified >> in accordance with what GCC is expecting to find. >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Acked-by: Paul Bolle <pebolle@tiscali.nl> >
Thanks, Paul.
-- Gustavo
| |