Messages in this thread | | | From | Anup Patel <> | Date | Tue, 12 Feb 2019 17:35:32 +0530 | Subject | Re: [PATCH v5 2/5] irqchip: sifive-plic: Don't inline plic_toggle() and plic_irq_toggle() |
| |
On Tue, Feb 12, 2019 at 12:39 PM Christoph Hellwig <hch@infradead.org> wrote: > > On Sat, Jan 19, 2019 at 11:26:22AM +0530, Anup Patel wrote: > > The plic_toggle() uses raw_spin_lock() and plic_irq_toggle has a > > for loop so both these functions are not suitable for being inline > > hence this patch removes the inline keyword. > > I still very much disagree. Very strongly with the above rationale, > but also (less strongly) with the decision not to inline here.
No issues. I will drop this patch since you "very much disagree".
Regards, Anup
| |