lkml.org 
[lkml]   [2019]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] ima: fix build error redeclaration of enumerator
On Tue, Feb 12, 2019 at 12:21 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Feb 12, 2019 at 12:15 PM Anders Roxell <anders.roxell@linaro.org> wrote:
> >
> > Commit a893ea15d764 ("tpm: move tpm_chip definition to
> > include/linux/tpm.h") introduced a build error when both ima and efi is
> > enabled. What happens is that both headers (ima.h and efi.h) defines the
> > same 'NONE' constant, and it broke when they started getting included
> > from the same file.
>
> > We only need one of the two patches applied.
>
> I would argue that we need two patches applied. Namespace is a hidden
> issue in the code.
>
> This patch looks good to me, FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Oh, did you change ABI? So, I have to say that enum changes are okay,
but ABI, if any, are not.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-02-12 11:24    [W:0.173 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site