Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 12 Feb 2019 12:23:24 +0200 | Subject | Re: [PATCH 1/2] ima: fix build error redeclaration of enumerator |
| |
On Tue, Feb 12, 2019 at 12:21 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Tue, Feb 12, 2019 at 12:15 PM Anders Roxell <anders.roxell@linaro.org> wrote: > > > > Commit a893ea15d764 ("tpm: move tpm_chip definition to > > include/linux/tpm.h") introduced a build error when both ima and efi is > > enabled. What happens is that both headers (ima.h and efi.h) defines the > > same 'NONE' constant, and it broke when they started getting included > > from the same file. > > > We only need one of the two patches applied. > > I would argue that we need two patches applied. Namespace is a hidden > issue in the code. > > This patch looks good to me, FWIW, > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Oh, did you change ABI? So, I have to say that enum changes are okay, but ABI, if any, are not.
-- With Best Regards, Andy Shevchenko
| |