Messages in this thread | | | Date | Tue, 12 Feb 2019 10:01:31 +0100 | From | Greg KH <> | Subject | Re: [PATCH 1/2] chardev: fix an overlap misjudgement case in __register_chrdev_region() |
| |
On Tue, Feb 12, 2019 at 04:47:38PM +0800, Chengguang Xu wrote: > Current overlap check of minor range cannot correctly > handle a case which is baseminor < existing baseminor && > baseminor + minorct > existing baseminor + minorct. > Fix it and meanwhile do some code cleanups.
Ick, don't do a fix and "code cleanups" in the same patch, that makes it almost impossible to see what the "fix" really was.
That should be two separate patches, please break this up.
thanks,
greg k-h
| |