Messages in this thread | | | From | Pi-Hsun Shih <> | Date | Tue, 12 Feb 2019 16:47:03 +0800 | Subject | Re: [PATCH] checkpatch: Properly detect /* */ style SPDX header. |
| |
On Fri, Feb 1, 2019 at 12:54 AM Joe Perches <joe@perches.com> wrote: > > On Thu, 2019-01-31 at 17:56 +0800, Pi-Hsun Shih wrote: > > Currently for a header line "/* SPDX-License-Identifier: GPL-2.0 */", > > only the part starting from "SPDX-" is passed to spdxcheck.py, and cause > > false warning. Fix this by passing the whole line to spdxcheck.py > > instead. > > Thanks but I submitted a different patch: > > https://lore.kernel.org/lkml/8b02899853247a2c67669561761f354dd3bd110e.camel@perches.com/ >
I tried your patch, but when running checkpatch.pl on https://patchwork.kernel.org/patch/10790203/, I still get: WARNING: 'SPDX-License-Identifier: GPL-2.0 */' is not supported in LICENSES/... #75: FILE: drivers/remoteproc/mtk_common.h:1: +/* SPDX-License-Identifier: GPL-2.0 */
Feels that these two patches fix different issues.
| |