lkml.org 
[lkml]   [2019]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.4 04/16] mfd: ab8500-core: Return zero in get_register_interruptible()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 10628e3ecf544fa2e4e24f8e112d95c37884dc98 ]

    This function is supposed to return zero on success or negative error
    codes on error. Unfortunately, there is a bug so it sometimes returns
    non-zero, positive numbers on success.

    I noticed this bug during review and I can't test it. It does appear
    that the return is sometimes propogated back to _regmap_read() where all
    non-zero returns are treated as failure so this may affect run time.

    Fixes: 47c1697508f2 ("mfd: Align ab8500 with the abx500 interface")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mfd/ab8500-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
    index fefbe4cfa61d..1263cfd8b4d2 100644
    --- a/drivers/mfd/ab8500-core.c
    +++ b/drivers/mfd/ab8500-core.c
    @@ -259,7 +259,7 @@ static int get_register_interruptible(struct ab8500 *ab8500, u8 bank,
    mutex_unlock(&ab8500->lock);
    dev_vdbg(ab8500->dev, "rd: addr %#x => data %#x\n", addr, ret);

    - return ret;
    + return (ret < 0) ? ret : 0;
    }

    static int ab8500_get_register(struct device *dev, u8 bank,
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-02-13 03:44    [W:2.134 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site