Messages in this thread | | | Date | Tue, 12 Feb 2019 09:26:21 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH 5/5] riscv: use for_each_of_cpu_node iterator |
| |
On Mon, Feb 11, 2019 at 11:13:39PM -0800, Christoph Hellwig wrote: > On Fri, Jan 18, 2019 at 03:03:08PM +0100, Johan Hovold wrote: > > Use the new for_each_of_cpu_node() helper to iterate over cpu nodes > > instead of open coding. Note that this will allow matching also on the > > node name instead of the (for FDT) deprecated device_type property. > > > > Signed-off-by: Johan Hovold <johan@kernel.org> > > I think this is going to conflict with the ELF caps changes from > Atish. Maybe the riscv_fill_hwcap hunk should be included in his > patch?
Since that patch had some issues (e.g. the node reference underflow) it may be better to rebase it on top of this series. The changes are otherwise distinct after all.
> Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for reviewing!
Johan
| |