lkml.org 
[lkml]   [2019]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] audit: mark expected switch fall-through
On Tue, Feb 12, 2019 at 3:46 PM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> kernel/auditfilter.c: In function ‘audit_krule_to_data’:
> kernel/auditfilter.c:668:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (krule->pflags & AUDIT_LOGINUID_LEGACY && !f->val) {
> ^
> kernel/auditfilter.c:674:3: note: here
> default:
> ^~~~~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> kernel/auditfilter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Merged into audit/next, thanks.

--
paul moore
www.paul-moore.com

\
 
 \ /
  Last update: 2019-02-13 02:20    [W:0.083 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site