lkml.org 
[lkml]   [2019]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rtc: rv3028: new driver
On 30/01/2019 17:13:27+0100, Marek Vasut wrote:
> On 1/30/19 4:00 PM, Alexandre Belloni wrote:
> > Add a driver for the MicroCrystal RV-3028.
>
> Some additional information in the commit message won't hurt.
>
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > ---
> > Documentation/devicetree/bindings/rtc/rtc.txt | 1 +
> > drivers/rtc/Kconfig | 9 +
> > drivers/rtc/Makefile | 1 +
> > drivers/rtc/rtc-rv3028.c | 732 ++++++++++++++++++
> > 4 files changed, 743 insertions(+)
> > create mode 100644 drivers/rtc/rtc-rv3028.c
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/rtc.txt b/Documentation/devicetree/bindings/rtc/rtc.txt
> > index d86e2850fe1c..3e6a215e7304 100644
> > --- a/Documentation/devicetree/bindings/rtc/rtc.txt
> > +++ b/Documentation/devicetree/bindings/rtc/rtc.txt
> > @@ -52,6 +52,7 @@ emmicro,em3027 EM Microelectronic EM3027 Real-time Clock
> > isil,isl1208 Intersil ISL1208 Low Power RTC with Battery Backed SRAM
> > isil,isl1218 Intersil ISL1218 Low Power RTC with Battery Backed SRAM
> > isil,isl12022 Intersil ISL12022 Real-time Clock
> > +microcrystal,rv3028 Real Time Clock Module with I2C-Bus
>
> Shouldn't this be a separate patch ?
>

Not really as this doesn't introduce any new binding and simply
documents a compatible string. Rob is loaded enough to not review that
kind of changes.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2019-02-13 00:22    [W:0.082 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site