Messages in this thread | | | Subject | Re: [PATCH] isdn: i4l: isdn_tty: Mark expected switch fall-through | From | "Gustavo A. R. Silva" <> | Date | Tue, 12 Feb 2019 15:32:21 -0600 |
| |
Thanks, Dave.
-- Gustavo
On 2/12/19 12:29 PM, David Miller wrote: > From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> > Date: Mon, 11 Feb 2019 16:38:21 -0600 > >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >> drivers/isdn/i4l/isdn_tty.c: In function ‘isdn_tty_edit_at’: >> drivers/isdn/i4l/isdn_tty.c:3644:18: warning: this statement may fall through [-Wimplicit-fallthrough=] >> m->mdmcmdl = 0; >> ~~~~~~~~~~~^~~ >> drivers/isdn/i4l/isdn_tty.c:3646:5: note: here >> case 0: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> Notice that, in this particular case, the code comment is modified >> in accordance with what GCC is expecting to find. >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Applied. >
| |