lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 347/352] perf tests evsel-tp-sched: Fix bitwise operator
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gustavo A. R. Silva <gustavo@embeddedor.com>

    commit 489338a717a0dfbbd5a3fabccf172b78f0ac9015 upstream.

    Notice that the use of the bitwise OR operator '|' always leads to true
    in this particular case, which seems a bit suspicious due to the context
    in which this expression is being used.

    Fix this by using bitwise AND operator '&' instead.

    This bug was detected with the help of Coccinelle.

    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    Acked-by: Jiri Olsa <jolsa@kernel.org>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: stable@vger.kernel.org
    Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields")
    Link: http://lkml.kernel.org/r/20190122233439.GA5868@embeddedor
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    tools/perf/tests/evsel-tp-sched.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/tools/perf/tests/evsel-tp-sched.c
    +++ b/tools/perf/tests/evsel-tp-sched.c
    @@ -17,7 +17,7 @@ static int perf_evsel__test_field(struct
    return -1;
    }

    - is_signed = !!(field->flags | TEP_FIELD_IS_SIGNED);
    + is_signed = !!(field->flags & TEP_FIELD_IS_SIGNED);
    if (should_be_signed && !is_signed) {
    pr_debug("%s: \"%s\" signedness(%d) is wrong, should be %d\n",
    evsel->name, name, is_signed, should_be_signed);

    \
     
     \ /
      Last update: 2019-02-11 15:38    [W:3.641 / U:0.860 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site