lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 08/15] PCI: endpoint: Fix pci_epf_alloc_space to set correct MEM TYPE flags
    On Mon, Jan 14, 2019 at 04:45:06PM +0530, Kishon Vijay Abraham I wrote:
    > pci_epf_alloc_space() sets the MEM TYPE flags to indicate a 32-bit
    > Base Address Register irrespective of the size. Fix it here to indicate
    > 64-bit BAR if the size is > 2GB.
    >
    > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    > ---
    > drivers/pci/endpoint/pci-epf-core.c | 4 +++-
    > 1 file changed, 3 insertions(+), 1 deletion(-)

    This looks like a fix and should me marked as such. Does it work
    as as standalone patch if it gets backported ?

    Lorenzo

    > diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c
    > index 825fa24427a3..8bfdcd291196 100644
    > --- a/drivers/pci/endpoint/pci-epf-core.c
    > +++ b/drivers/pci/endpoint/pci-epf-core.c
    > @@ -131,7 +131,9 @@ void *pci_epf_alloc_space(struct pci_epf *epf, size_t size, enum pci_barno bar)
    > epf->bar[bar].phys_addr = phys_addr;
    > epf->bar[bar].size = size;
    > epf->bar[bar].barno = bar;
    > - epf->bar[bar].flags = PCI_BASE_ADDRESS_SPACE_MEMORY;
    > + epf->bar[bar].flags |= upper_32_bits(size) ?
    > + PCI_BASE_ADDRESS_MEM_TYPE_64 :
    > + PCI_BASE_ADDRESS_MEM_TYPE_32;
    >
    > return space;
    > }
    > --
    > 2.17.1
    >

    \
     
     \ /
      Last update: 2019-02-11 18:38    [W:3.793 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site