lkml.org 
[lkml]   [2019]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 276/352] thermal: tsens: qcom: do not create duplicate regmap debugfs entries
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 4ab248b3b10a58e379e2d32333fff99ea5ca256c ]

    Regmap would use device name to create debugfs entries. If the device
    has multiple regmaps it is recommended to use name field in regmap_config.
    Fix this by providing name to the regmap configs correctly.

    Without this patch we would see below error on DB820c.

    qcom-tsens 4a9000.thermal-sensor: Failed to create 4a9000.thermal-sensor
    debugfs directory

    Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
    Tested-by: Amit Kucheria <amit.kucheria@linaro.org>
    Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/thermal/qcom/tsens-common.c | 12 ++++++++++--
    1 file changed, 10 insertions(+), 2 deletions(-)

    diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
    index 3be4be2e0465..78652cac7f3d 100644
    --- a/drivers/thermal/qcom/tsens-common.c
    +++ b/drivers/thermal/qcom/tsens-common.c
    @@ -114,6 +114,14 @@ int get_temp_common(struct tsens_device *tmdev, int id, int *temp)
    }

    static const struct regmap_config tsens_config = {
    + .name = "tm",
    + .reg_bits = 32,
    + .val_bits = 32,
    + .reg_stride = 4,
    +};
    +
    +static const struct regmap_config tsens_srot_config = {
    + .name = "srot",
    .reg_bits = 32,
    .val_bits = 32,
    .reg_stride = 4,
    @@ -139,8 +147,8 @@ int __init init_common(struct tsens_device *tmdev)
    if (IS_ERR(srot_base))
    return PTR_ERR(srot_base);

    - tmdev->srot_map = devm_regmap_init_mmio(tmdev->dev,
    - srot_base, &tsens_config);
    + tmdev->srot_map = devm_regmap_init_mmio(tmdev->dev, srot_base,
    + &tsens_srot_config);
    if (IS_ERR(tmdev->srot_map))
    return PTR_ERR(tmdev->srot_map);

    --
    2.19.1


    \
     
     \ /
      Last update: 2019-02-11 16:56    [W:3.288 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site