Messages in this thread | | | From | Sven Van Asbroeck <> | Date | Sun, 10 Feb 2019 18:47:11 -0500 | Subject | Re: [PATCH] Input: qt2160 - switch to using brightness_set_blocking() |
| |
On Sat, Feb 9, 2019 at 12:21 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > Now that LEDs core allows "blocking" flavor of "set brightness" method we > can use it and get rid of private work items. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Looking good !
Reviewed-by: Sven Van Asbroeck <TheSven73@gmail.com>
Good job to get rid of that led_lock mutex. It didn't serve any purpose but more importantly, it could introduce a sleep in brightness_set, which cannot sleep...
| |