Messages in this thread | | | From | Sven Van Asbroeck <> | Date | Sun, 10 Feb 2019 17:03:22 -0500 | Subject | Re: [PATCH] auxdisplay: ht16k33: fix potential user-after-free on module unload |
| |
On Fri, Feb 8, 2019 at 7:15 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On module unload/remove, we need to ensure that work does not run > after we have freed resources. Concretely, cancel_delayed_work() > may return while the callback function is still running. > > From kernel/workqueue.c: > > The work callback function may still be running on return, > unless it returns true and the work doesn't re-arm itself. > Explicitly flush or use cancel_delayed_work_sync() to wait on it. > > Link: https://lore.kernel.org/lkml/20190204220952.30761-1-TheSven73@googlemail.com/ > Reported-by: Sven Van Asbroeck <thesven73@gmail.com> > Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Yes, this should do the trick.
Reviewed-by: Sven Van Asbroeck <TheSven73@gmail.com>
| |