lkml.org 
[lkml]   [2019]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] media: allegro: add the missed check for v4l2_m2m_ctx_init
    On Mon, Dec 09, 2019 at 04:58:07PM +0800, Chuhong Yuan wrote:
    > diff --git a/drivers/staging/media/allegro-dvt/allegro-core.c b/drivers/staging/media/allegro-dvt/allegro-core.c
    > index 6f0cd0784786..5f1d454b41bb 100644
    > --- a/drivers/staging/media/allegro-dvt/allegro-core.c
    > +++ b/drivers/staging/media/allegro-dvt/allegro-core.c
    > @@ -2341,6 +2341,13 @@ static int allegro_open(struct file *file)
    > channel->fh.m2m_ctx = v4l2_m2m_ctx_init(dev->m2m_dev, channel,
    > allegro_queue_init);
    >
    > + if (IS_ERR(channel->fh.m2m_ctx)) {
    > + v4l2_fh_del(&channel->fh);
    > + v4l2_fh_exit(&channel->fh);
    > + kfree(channel);
    ^^^^^^^
    Free

    > + return PTR_ERR(channel->fh.m2m_ctx);
    ^^^^^^^^^^^^^^^^^^^
    Dereferencing freed memory.

    regards,
    dan carpenter

    > + }
    > +

    \
     
     \ /
      Last update: 2019-12-09 19:58    [W:6.403 / U:1.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site