Messages in this thread | | | Date | Mon, 09 Dec 2019 20:29:20 -0800 (PST) | Subject | Re: [PATCH] net: tulip: Adjust indentation in {dmfe,uli526x}_init_module | From | David Miller <> |
| |
From: Nathan Chancellor <natechancellor@gmail.com> Date: Mon, 9 Dec 2019 14:16:23 -0700
> Clang warns: > > ../drivers/net/ethernet/dec/tulip/uli526x.c:1812:3: warning: misleading > indentation; statement is not part of the previous 'if' > [-Wmisleading-indentation] > switch (mode) { > ^ > ../drivers/net/ethernet/dec/tulip/uli526x.c:1809:2: note: previous > statement is here > if (cr6set) > ^ > 1 warning generated. > > ../drivers/net/ethernet/dec/tulip/dmfe.c:2217:3: warning: misleading > indentation; statement is not part of the previous 'if' > [-Wmisleading-indentation] > switch(mode) { > ^ > ../drivers/net/ethernet/dec/tulip/dmfe.c:2214:2: note: previous > statement is here > if (cr6set) > ^ > 1 warning generated. > > This warning occurs because there is a space before the tab on these > lines. Remove them so that the indentation is consistent with the Linux > kernel coding style and clang no longer warns. > > While we are here, adjust the default block in dmfe_init_module to have > a proper break between the label and assignment and add a space between > the switch and opening parentheses to avoid a checkpatch warning. > > Fixes: e1c3e5014040 ("[PATCH] initialisation cleanup for ULI526x-net-driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/795 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied, but it's really crummy that the tool gets tripped up by the fact that a space preceeds the TAB. It's what the code visually looks like, not what exact kinds of SPACE characters were used to get there.
| |