Messages in this thread | | | Date | Sat, 7 Dec 2019 12:44:44 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: Fix memory leak in psxpad_spi_probe |
| |
On Tue, Nov 26, 2019 at 10:34:34AM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 22, 2019 at 11:02:08AM -0800, Dmitry Torokhov wrote: > > Hi Navid, > > > > On Thu, Nov 21, 2019 at 02:01:11PM -0600, Navid Emamdoost wrote: > > > In the implementation of psxpad_spi_probe() the allocated memory for > > > pdev is leaked if psxpad_spi_init_ff() or input_register_polled_device() > > > fail. The solution is using device managed allocation, like the one used > > > for pad. Perform the allocation using > > > devm_input_allocate_polled_device(). > > > > > > Fixes: 8be193c7b1f4 ("Input: add support for PlayStation 1/2 joypads connected via SPI") > > > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> > > > > This is fixed in the current version of the driver, but you can send it > > to stable@gerkernel.orf with my > > Was it fixed by any specific patch, or just a side-affect of some other > larger change?
It was fixed "by accident" when I converted the driver from using input_polled_dev to standard input device in polled mode.
Thanks.
-- Dmitry
| |