lkml.org 
[lkml]   [2019]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] crypto: caam: Change the i.MX8MQ check support all i.MX8M variants
    On Wed, Dec 4, 2019 at 5:38 AM Schrempf Frieder
    <frieder.schrempf@kontron.de> wrote:
    >
    > Hi Adam,
    >
    > On 30.11.19 23:51, Adam Ford wrote:
    > > The i.MX8M Mini uses the same crypto engine as the i.MX8MQ, but
    > > the driver is restricting the check to just the i.MX8MQ.
    > >
    > > This patch lets the driver support all i.MX8M Variants if enabled.
    > >
    > > Signed-off-by: Adam Ford <aford173@gmail.com>
    >
    > What about the following lines in run_descriptor_deco0()? Does this
    > condition also apply to i.MX8MM?

    I think that's a question for NXP. I am not seeing that in the NXP
    Linux Release, and I don't have an 8MQ to compare.

    I was able to get the driver working on the i.MXMM with the patch.

    NXP Team,

    Do you have any opinions on this?

    adam
    >
    > drivers/crypto/caam/ctrl.c:
    >
    > if (ctrlpriv->virt_en == 1 ||
    > /*
    > * Apparently on i.MX8MQ it doesn't matter if virt_en == 1
    > * and the following steps should be performed regardless
    > */
    > of_machine_is_compatible("fsl,imx8mq")) {
    > clrsetbits_32(&ctrl->deco_rsr, 0, DECORSR_JR0);
    >
    > while (!(rd_reg32(&ctrl->deco_rsr) & DECORSR_VALID) &&
    > --timeout)
    > cpu_relax();
    >
    > timeout = 100000;
    > }
    >
    > Regards,
    > Frieder
    >
    > >
    > > diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
    > > index db22777d59b4..1ce03f8961b6 100644
    > > --- a/drivers/crypto/caam/ctrl.c
    > > +++ b/drivers/crypto/caam/ctrl.c
    > > @@ -527,7 +527,7 @@ static const struct soc_device_attribute caam_imx_soc_table[] = {
    > > { .soc_id = "i.MX6UL", .data = &caam_imx6ul_data },
    > > { .soc_id = "i.MX6*", .data = &caam_imx6_data },
    > > { .soc_id = "i.MX7*", .data = &caam_imx7_data },
    > > - { .soc_id = "i.MX8MQ", .data = &caam_imx7_data },
    > > + { .soc_id = "i.MX8M*", .data = &caam_imx7_data },
    > > { .family = "Freescale i.MX" },
    > > { /* sentinel */ }
    > > };
    > >

    \
     
     \ /
      Last update: 2019-12-06 20:57    [W:7.929 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site