Messages in this thread | | | Date | Fri, 6 Dec 2019 10:20:40 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCH] ARM: OMAP2+: Fix warnings with broken omap2_set_init_voltage() |
| |
* H. Nikolaus Schaller <hns@goldelico.com> [191203 16:55]: > > What we could do is augment the printk (or dev_err) to tell > > in these warnings what it is looking for... > > > > opp = dev_pm_opp_find_freq_ceil(dev, &freq); > > if (IS_ERR(opp)) { > > pr_err("%s: unable to find boot up OPP for vdd_%s freq %ulHz\n", > > __func__, vdd_name, freq); > > goto exit; > > } > > Easier and always prints info: > > freq = clk_get_rate(clk); > clk_put(clk); > > pr_info("%s: vdd=%s clk=%s %luHz oh=%s\n", __func__, vdd_name, clk_name, freq, oh_name); > > opp = dev_pm_opp_find_freq_ceil(dev, &freq); > > I get this: > > [ 2.908142] omap2_set_init_voltage: vdd=mpu_iva clk=dpll1_ck 1000000000Hz oh=mpu > [ 2.930816] omap2_set_init_voltage: vdd=core clk=l3_ick 200000000Hz oh=l3_main > [ 2.946228] omap2_set_init_voltage: unable to find boot up OPP for vdd_core > [ 2.953460] omap2_set_init_voltage: unable to set vdd_core
OK yeah that's more descriptive.
> Which means that cpufreq already has increased dpll1_ck to 1 GHz > (I have removed the turbo-mode tags so that it already boots at > full speed) and l3_ick runs at initial 200 MHz.
OK. I wonder where this initial code should live though..
Regards,
Tony
| |