Messages in this thread Patch in this message | | | From | Martin Kepplinger <> | Subject | Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling | Date | Fri, 6 Dec 2019 12:33:15 +0100 |
| |
I tested this on the librem5-devkit and see the cooling devices in sysfs. I configure ARM_PSCI_CPUIDLE, not ARM_CPUIDLE and add the patch below in register the cooling device there. "psci_idle" is listed as the cpuidle_driver.
That's what I'm running, in case you want to see it all: https://source.puri.sm/martin.kepplinger/linux-next/commits/next-20191205/librem5_cpuidle_mainline_atf
so I add a trip temperature description like this: https://source.puri.sm/martin.kepplinger/linux-next/commit/361f49f93ae2c477fd012790831cabd0ed976660
When I let the SoC heat up, cpuidle cooling won't kick it. In sysfs:
catting the relevant files in /sys/class/thermal after heating up, if that makes sense:
87000 85000 85000 thermal-cpufreq-0 1 thermal-idle-0 0 thermal-idle-1 0 thermal-idle-2 0 thermal-idle-3 0
with ARM_CPUIDLE instead of ARM_PSCI_CPUIDLE (and registering the cooling dev during cpuidle-arm.c init) I won't have a cpuidle driver and thus no cpu-sleep state at all.
Can you see where the problem here lies?
thanks!
martin
--- drivers/cpuidle/cpuidle-psci.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c index f3c1a2396f98..de6e7f444a66 100644 --- a/drivers/cpuidle/cpuidle-psci.c +++ b/drivers/cpuidle/cpuidle-psci.c @@ -8,6 +8,7 @@ #define pr_fmt(fmt) "CPUidle PSCI: " fmt +#include <linux/cpu_cooling.h> #include <linux/cpuidle.h> #include <linux/cpumask.h> #include <linux/cpu_pm.h> @@ -195,6 +196,8 @@ static int __init psci_idle_init_cpu(int cpu) if (ret) goto out_kfree_drv; + cpuidle_cooling_register(drv); + return 0; out_kfree_drv: -- 2.20.1
| |