lkml.org 
[lkml]   [2019]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] tty: serial: samsung: support driver modulization

    A: Because it messes up the order in which people normally read text.
    Q: Why is top-posting such a bad thing?
    A: Top-posting.
    Q: What is the most annoying thing in e-mail?

    A: No.
    Q: Should I include quotations after my reply?

    http://daringfireball.net/2007/07/on_top

    On Fri, Dec 06, 2019 at 10:44:20AM +0900, ������/HYUN-KI KOO wrote:
    > To support module for Samsung serial driver,
    > I would like to split the file into 2 files.

    But you did not do that here in this patch, right?

    > Because it cannot be supported in one file both early console and
    > module driver
    > Thus some function need to change to EXPORT_SYMBOL to use in module
    > driver file.
    > I'm not pushed yet for module driver.

    I do not understand, this patch feels wrong and incomplete as-is, right?
    Please fix it up to work properly.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2019-12-06 07:41    [W:3.045 / U:1.944 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site