lkml.org 
[lkml]   [2019]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2 25/28] drm: rcar-du: lvds: Use drm_bridge_init()
Hi Mihail,

Thank you for the patch.

On Wed, Dec 04, 2019 at 11:48:23AM +0000, Mihail Atanassov wrote:
> No functional change.
>
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>

If you squash this with 26/28,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 8c6c172bbf2e..ac1f29bacfcb 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -881,9 +881,8 @@ static int rcar_lvds_probe(struct platform_device *pdev)
> if (ret < 0)
> return ret;
>
> - lvds->bridge.driver_private = lvds;
> - lvds->bridge.funcs = &rcar_lvds_bridge_ops;
> - lvds->bridge.of_node = pdev->dev.of_node;
> + drm_bridge_init(&lvds->bridge, &pdev->dev, &rcar_lvds_bridge_ops,
> + NULL, lvds);
>
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> lvds->mmio = devm_ioremap_resource(&pdev->dev, mem);

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2019-12-05 14:32    [W:0.051 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site