Messages in this thread | | | Date | Thu, 5 Dec 2019 13:59:04 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net v2] net: thunderx: start phy before starting autonegotiation |
| |
On Thu, Dec 05, 2019 at 10:41:16AM +0100, Mian Yousaf Kaukab wrote: > Since commit 2b3e88ea6528 ("net: phy: improve phy state checking") > phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start() > before calling phy_start_aneg() during probe so that autonegotiation > is initiated. > > As phy_start() takes care of calling phy_start_aneg(), drop the explicit > call to phy_start_aneg(). > > Network fails without this patch on Octeon TX. > > Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking") > Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |